[PATCH 2/3] reiserfs: use proper little-endian bitops

From: Akinobu Mita
Date: Mon May 30 2011 - 09:52:36 EST


Using __test_and_{set,clear}_bit_le() with ignoring its return value
can be replaced with __{set,clear}_bit_le().

Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
Cc: reiserfs-devel@xxxxxxxxxxxxxxx
---
fs/reiserfs/bitmap.c | 3 +--
fs/reiserfs/resize.c | 6 +++---
2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/fs/reiserfs/bitmap.c b/fs/reiserfs/bitmap.c
index f70dd69..f9e26c1 100644
--- a/fs/reiserfs/bitmap.c
+++ b/fs/reiserfs/bitmap.c
@@ -212,8 +212,7 @@ static int scan_bitmap_block(struct reiserfs_transaction_handle *th,
}
/* otherwise we clear all bit were set ... */
while (--i >= *beg)
- __test_and_clear_bit_le
- (i, bh->b_data);
+ __clear_bit_le(i, bh->b_data);
reiserfs_restore_prepared_buffer(s, bh);
*beg = org;
/* ... and search again in current block from beginning */
diff --git a/fs/reiserfs/resize.c b/fs/reiserfs/resize.c
index 1e6f4c2..cd17ae2 100644
--- a/fs/reiserfs/resize.c
+++ b/fs/reiserfs/resize.c
@@ -136,7 +136,7 @@ int reiserfs_resize(struct super_block *s, unsigned long block_count_new)
return -EIO;
}
memset(bh->b_data, 0, sb_blocksize(sb));
- __test_and_set_bit_le(0, bh->b_data);
+ __set_bit_le(0, bh->b_data);
reiserfs_cache_bitmap_metadata(s, bh, bitmap + i);

set_buffer_uptodate(bh);
@@ -172,7 +172,7 @@ int reiserfs_resize(struct super_block *s, unsigned long block_count_new)

reiserfs_prepare_for_journal(s, bh, 1);
for (i = block_r; i < s->s_blocksize * 8; i++)
- __test_and_clear_bit_le(i, bh->b_data);
+ __clear_bit_le(i, bh->b_data);
info->free_count += s->s_blocksize * 8 - block_r;

journal_mark_dirty(&th, s, bh);
@@ -190,7 +190,7 @@ int reiserfs_resize(struct super_block *s, unsigned long block_count_new)

reiserfs_prepare_for_journal(s, bh, 1);
for (i = block_r_new; i < s->s_blocksize * 8; i++)
- __test_and_set_bit_le(i, bh->b_data);
+ __set_bit_le(i, bh->b_data);
journal_mark_dirty(&th, s, bh);
brelse(bh);

--
1.7.4.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/