Re: [PATCH] ARM: Xilinx: Adding zynq platform support

[Grant Likely]

On Thu, May 26, 2011 at 11:25:12PM +0100, Russell King - ARM Linux wrote:
> On Thu, May 26, 2011 at 04:16:10PM -0600, Grant Likely wrote:
> > Will you pick up the zynq patch also?
> 
> It's about 1000 new lines, and I'm not sure Linus will take that
> level of addition - certainly not without explanation.
> 
> Also, if we adhere to the policy that we don't introduce new code
> which should be using the consolidated code which we've already
> introduced, this would need to be updated to use the mmio
> clocksource stuff at the very least.
> 
> I'm also not convinced that this platform would have the ICST PLL
> chips on it, so why it needs to select ICST I'm not sure (as well
> as having the PLL parameters in its struct clk.)

This is because it is reusing some of the versatile struct clk
implementation instead of cloning it's own set of plat-zynq stuff.  I
recommended to John to not create a completely new struct clk, and
that Versatile was probable the most generic of the lot.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/