Re: [PATCH v2] crypto: sha1: modify sha1_update to useSHA1_BLOCK_SIZE

[Herbert Xu]

On Thu, May 26, 2011 at 04:20:58PM -0700, Mandeep Singh Baines wrote:
> David Miller (davem@xxxxxxxxxxxxx) wrote:
> > 
> > The temp[] buffer is explicitly places inside the inner most
> > basic block so that the compiler doesn't allocate the stack
> > space unless that code path is taken.
> > 
> 
> Fixed in V2 (this patch). Thanks for the review.
> 
> -- >8 -- (snip)
> 
> Plus some other minor cleanup.

I don't really like the cleanups.  In any case, mixing up the
use of SHA1_BLOCK_SIZE with cleanups increases the chance of
introducing a bug.

So please redo the patch with only the addition of SHA1_BLOCK_SIZE
and nothing else.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/