Re: [PATCH 2/2] staging/iio: Make IIO depend on GENERIC_HARDIRQS

[jonathan.cameron@xxxxxxxxx]

Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:

>On m68k (which doesn't support generic hardirqs yet):
>
>drivers/staging/iio/industrialio-trigger.c: In function
>âiio_trigger_pollâ:
>drivers/staging/iio/industrialio-trigger.c:180: error: implicit
>declaration of function âgeneric_handle_irqâ
>drivers/staging/iio/industrialio-trigger.c: In function
>âiio_trigger_poll_chainedâ:
>drivers/staging/iio/industrialio-trigger.c:200: error: implicit
>declaration of function âhandle_nested_irqâ
>drivers/staging/iio/industrialio-trigger.c: In function
>âiio_trig_releaseâ:
>drivers/staging/iio/industrialio-trigger.c:379: error: implicit
>declaration of function âirq_modify_statusâ
>drivers/staging/iio/industrialio-trigger.c:382: error: implicit
>declaration of function âirq_set_chipâ
>drivers/staging/iio/industrialio-trigger.c:384: error: implicit
>declaration of function âirq_set_handlerâ
>drivers/staging/iio/industrialio-trigger.c:388: error: implicit
>declaration of function âirq_free_descsâ
>drivers/staging/iio/industrialio-trigger.c: In function
>âiio_trig_subirqmaskâ:
>drivers/staging/iio/industrialio-trigger.c:402: error: implicit
>declaration of function âirq_data_get_irq_chipâ
>drivers/staging/iio/industrialio-trigger.c:402: warning: initialization
>makes pointer from integer without a cast
>drivers/staging/iio/industrialio-trigger.c: In function
>âiio_trig_subirqunmaskâ:
>drivers/staging/iio/industrialio-trigger.c:411: warning: initialization
>makes pointer from integer without a cast
>drivers/staging/iio/industrialio-trigger.c: In function
>âiio_allocate_triggerâ:
>drivers/staging/iio/industrialio-trigger.c:432: error: implicit
>declaration of function âirq_alloc_descsâ
>drivers/staging/iio/industrialio-trigger.c:455: error:
>âhandle_simple_irqâ undeclared (first use in this function)
>drivers/staging/iio/industrialio-trigger.c:455: error: (Each undeclared
>identifier is reported only once
>drivers/staging/iio/industrialio-trigger.c:455: error: for each
>function it appears in.)
>
>Hence IIO_TRIGGER should depend on GENERIC_HARDIRQS.
>But as IIO_TRIGGER and IIO_RING_BUFFER form a maze of dependencies and
>selects,
>just make the whole IIO subsystem depend on GENERIC_HARDIRQS.
>
>This dependency also covers !S390, so that one can be removed again.
Dratt  We talked about this and thought S390 was the only non generic hard irq left.  Should have played safe sorry!
>Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Acked-by: Jonathan Cameron <jic23@xxxxxxxxx>
>---
> drivers/staging/iio/Kconfig |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/staging/iio/Kconfig b/drivers/staging/iio/Kconfig
>index f96d5b5..d329635 100644
>--- a/drivers/staging/iio/Kconfig
>+++ b/drivers/staging/iio/Kconfig
>@@ -4,7 +4,7 @@
> 
> menuconfig IIO
> 	tristate "Industrial I/O support"
>-	depends on !S390
>+	depends on GENERIC_HARDIRQS
> 	help
> 	  The industrial I/O subsystem provides a unified framework for
> 	  drivers for many different types of embedded sensors using a
>-- 
>1.7.0.4

-- 
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/