Re: perf cgroup per-task attaching

[Borislav Petkov]

On Tue, May 31, 2011 at 10:07:40AM -0400, Peter Zijlstra wrote:
> On Tue, 2011-05-31 at 16:03 +0200, Borislav Petkov wrote:
> > Just FYI:
> > 
> > I'm getting
> > 
> > kernel/events/core.c:7445: warning: initialization from incompatible pointer type
> > 
> > when building -rc1 with CONFIG_CGROUP_PERF enabled. AFAICT, this is
> > due to the fact that f780bdb7c1c73009cb57adcf99ef50027d80bf3c dropped
> > the threadgroup arg from cgroup_subsys->attach in favour of per-thread
> > callbacks.
> > 
> > perf_cgroup_attach() actually does reschedule the task context after
> > the cgroup changes so the perf cgroup code would need some non-trivial
> > adjusting to the new APIs.
> 
> lkml.kernel.org/r/tip-74c355fbdfedd3820046dba4f537876cea54c207@xxxxxxxxxxxxxx

Hehe, that happened today already! :)

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/