Re: [PATCH 1/2] ide-cd: Fix signedness warning

[David Miller]

From: Connor Hansen <cmdkhh@xxxxxxxxx>
Date: Mon, 30 May 2011 00:13:32 -0700

> One of the legit warnings 'make W=3 drivers/ide/ide-cd.o´ generates is
> 
> drivers/ide/ide-cd.c: In function .ide_cdrom_prep_fs.:
> drivers/ide/ide-cd.c:1314: warning: conversion to .unsigned int. from .int. may change the sign of the result
> 
> because queue_logical_block_size() returns unsigned short but hard_sect
> is defined as int. Fix that no matter how low the potential for this
> becoming a bug is.
> 
> Signed-off-by: Connor Hansen <cmdkhh@xxxxxxxxx>

An 'int' can always hold as large a value as an "unsigned short" can ever
hold, so there is no real problem here.

I'm not applying this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/