Re: [PATCH] init, calibrate: Drop annoying warning

[Borislav Petkov]

On Tue, May 31, 2011 at 07:04:59PM -0400, Andrew Worsley wrote:
> I can see your point - it's useful when debugging the bogomips issue -
> but if it's working it's not relevant.
> Would be nice to have an extra level of verbose debug or a debug
> branch of the file or perhaps just a relevant comment
> that would easily allow it to be found and reverted to re-enable debug
> if people want to debug this stuff again.

Well, your patch either fixes the issue so the debug statements can go
or it doesn't and needs more hammering :).

> That said I would suggest just changing the comment (I don't know how
> to just submit a comment change?) to something like:
> 
> "Drop calibrate_delay_direct() KERN_DEBUG printk related to bogomips
> calculation as it appears when booting
> every core on setups with 'ignore_loglevel' for people who want to
> test latest kernels and scan dmesg for possible issues.
> and this information isn't very useful to the widest audience of
> kernel boot message gazers."

Fair enough, will change and resubmit.

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/