Re: [stable] apparent regression (crash) - 2.6.38.6

[Atsushi Nemoto]

On Thu, 19 May 2011 07:39:27 +0400, James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, 2011-05-18 at 17:25 -0700, Greg KH wrote:
> > On Wed, May 11, 2011 at 12:34:51PM -0700, Greg KH wrote:
> > > On Wed, May 11, 2011 at 02:19:17PM -0500, James Bottomley wrote:
> > > > > > [  106.994628] BUG: unable to handle kernel NULL pointer dereference at 0000000000000048
> > > > > > [  106.994755] IP: [<ffffffff811bec1b>] elv_queue_empty+0x1b/0x30
> > > > 
> > > > Hmm, it's another missing elevator guard, like this patch:
> > > > 
> > > > http://marc.info/?l=linux-scsi&m=130348673628282
> > > > 
> > > > I think the bug here is that q->elevator is null, so dereferencing
> > > > elevator->ops gives the bug.
> > > 
> > > Is this patch going to Linus anytime soon?
> > 
> > Ping?
> 
> I pinged Jens about it yesterday; he said it should be on its way to
> Linus.

The patch in above URL ("block: add proper state guards to
__elv_next_request") is in mainline and stable-queues now, but how
about a similar fix for elv_queue_empty()?

The elv_queue_empty() is removed in mainline, but it seems
stable-2.6.38.x and prior stable-branches still need the fix for
elv_queue_empty().

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/