Re: [PATCH v2] trace: Add x86 irq vector entry/exit tracepoints

[David Sharp]

On Wed, Jun 1, 2011 at 3:38 PM, Vaibhav Nagarnaik <vnagarnaik@xxxxxxxxxx> wrote:
> On Tue, May 31, 2011 at 5:00 PM, Frederic Weisbecker
> <fweisbec@xxxxxxxxx> wrote:
>>
>> IIRC, Thomas suggested in the v1 to turn arch tracepoints into core ones when they
>> stand for generic (ie: shared by all archs) event meaning.
>>
>> I don't know where the discussion went after that, but that still seems to
>> me an important direction. Tracing irqs by their vector number should be reserved
>> for pure arch meanings. Sharing common tracepoints for generic events amongst archs makes life
>> easier for tools. Bonus when the tracepoint can be placed in the generic code.
>>
>
> I agree with you that the tracepoints should be as generic as possible
> to have them traced across platforms, but I see these tracepoints as
> specific to x86 platform. Since most of these vectors are x86 specific.
> The only ones that you pointed out as generic were:

I think what Vaibhav means is that this is "the one trace event for
all hard IRQs on the platform". A tracepoint for the cross-platform
irq handlers is also useful, but that is not the purpose of this
tracepoint. There's not actually much overlap between platforms for
IRQs, so each platform needs to do the work of covering all their
IRQs, and won't see much benefit from the generic tracepoints.

On Tue, May 31, 2011 at 5:00 PM, Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:
> Tracing irqs by their vector number should be reserved for pure arch meanings.

exactly, and this tracepoint is for that "arch meaning".

I'd also add that having these tracepoints here makes it more obvious
that we will get all IRQ events, which is what is important to us.

>
> LOCAL_TIMER_VECTOR - The generic callbacks that I found are in:
> kernel/time/tick-broadcast.c (tick_handle_periodic(),
> tick_handle_periodic_broadcast(), tick_handle_oneshot_broadcast()).
>
> RESCHEDULE_VECTOR - The callback is in kernel/sched.c (scheduler_ipi())
>
> CALL_FUNCTION_VECTOR - The callback is in kernel/smp.c
> (generic_smp_call_function_interrupt())
> CALL_FUNCTION_SINGLE_VECTOR - The callback is in kernel/smp.c
> (generic_smp_call_function_single_interrupt())
>
> IRQ_WORK_VECTOR - kernel/irq_work.c (irq_work_run())
>
> REBOOT_VECTOR - For x86, this does not enter any generic code. It is
> also not traced. The definition was in there only as part of the
> interrupt table.
>
> So, as I see it, there are only 5 vectors that enter the generic
> handling code of the kernel. The other vectors have platform specific
> handlers or are just x86 specific IRQs.
>
> This is the reason that I added the irq_vectors tracing class under the
> arch-specific code. If other platforms want to use the same event class,
> it can be initialized in their platform specific code for their use with
> the appropriate tracepoints added.
>
>
> Vaibhav Nagarnaik
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/