Re: [PATCH] sched: remove resetting exec_start in put_prev_task_rt()

[Yong Zhang]

On Wed, Jun 1, 2011 at 10:03 PM, Hillf Danton <dhillf@xxxxxxxxx> wrote:
> Resetting exec_start, after updated in update_curr_rt(), could open window for
> messing up the subsequent computations of delta_exec of the given task.

I can't see how could this happen. what kind of 'subsequent computations'
do you mean?

But because exec_start will be reset by _pick_next_task_rt()/set_curr_task_rt(),
you patch is ok. IMHO it is not critical, it's just cleanup instead.

Thanks,
Yong

>
> Signed-off-by: Hillf Danton <dhillf@xxxxxxxxx>
> ---
> Âkernel/sched_rt.c | Â Â1 -
> Â1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c
> index 88725c9..0f0cfce 100644
> --- a/kernel/sched_rt.c
> +++ b/kernel/sched_rt.c
> @@ -1166,7 +1166,6 @@ static struct task_struct
> *pick_next_task_rt(struct rq *rq)
> Âstatic void put_prev_task_rt(struct rq *rq, struct task_struct *p)
> Â{
> Â Â Â Âupdate_curr_rt(rq);
> - Â Â Â p->se.exec_start = 0;
>
> Â Â Â Â/*
> Â Â Â Â * The previous task needs to be made eligible for pushing
>



-- 
Only stand for myself
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/