Re: [PATCH v14 7/9] usb:gadget: Add SuperSpeed support to the GadgetFramework

[Felipe Balbi]

Hi,

On Tue, May 31, 2011 at 04:18:27PM +0300, Tatyana Brokhman wrote:
> @@ -377,9 +425,10 @@ static int config_desc(struct usb_composite_dev *cdev, unsigned w_value)
>  	u8				type = w_value >> 8;
>  	enum usb_device_speed		speed = USB_SPEED_UNKNOWN;
>  
> -	if (gadget_is_dualspeed(gadget)) {
> -		int			hs = 0;
> -
> +	if (gadget->speed == USB_SPEED_SUPER)

if (gadget_is_superspeed(gadget)) ??

> @@ -413,16 +469,22 @@ static int count_configs(struct usb_composite_dev *cdev, unsigned type)
>  	struct usb_configuration	*c;
>  	unsigned			count = 0;
>  	int				hs = 0;
> +	int				ss = 0;
>  
>  	if (gadget_is_dualspeed(gadget)) {
>  		if (gadget->speed == USB_SPEED_HIGH)
>  			hs = 1;
> +		if (gadget->speed == USB_SPEED_SUPER)
> +			ss = 1;

is this really correct under gadget_is_dualspeed() ?? puzzled.

-- 
balbi

Attachment: signature.asc
Description: Digital signature