Re: [PATCH] cs5535 mfgpt - fix wrong if condition

[Andrew Morton]

On Wed, 25 May 2011 19:08:06 +0000
Christian Gmeiner <christian.gmeiner@xxxxxxxxx> wrote:

> From: Christian Gmeiner <christian.gmeiner@xxxxxxxxx>
> 
> This patch fixes the wrong if condition for the check if the
> requested timer is available.
> 
> The bitmap avail is used to store if a timer is used already.
> test_bit() is used to check if the requested timer is
> available. If a bit in the avail bitmap is set it means that the
> timer is available.
> 
> Signed-off-by: Christian Gmeiner <christian.gmeiner@xxxxxxxxx>
> ---
>  drivers/misc/cs5535-mfgpt.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/misc/cs5535-mfgpt.c b/drivers/misc/cs5535-mfgpt.c
> index e01e08c..bc685bf 100644
> --- a/drivers/misc/cs5535-mfgpt.c
> +++ b/drivers/misc/cs5535-mfgpt.c
> @@ -174,7 +174,7 @@ struct cs5535_mfgpt_timer
> *cs5535_mfgpt_alloc_timer(int timer_nr, int domain)
>                 timer_nr = t < max ? (int) t : -1;
>         } else {
>                 /* check if the requested timer's available */
> -               if (test_bit(timer_nr, mfgpt->avail))
> +               if (!test_bit(timer_nr, mfgpt->avail))
>                         timer_nr = -1;
>         }
> 

What were the runtime effects of this bug?

(Please always include this information in the changelog when fixing things)

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/