Re: [stable] apparent regression (crash) - 2.6.38.6

[Atsushi Nemoto]

On Fri, 03 Jun 2011 11:01:37 +0400, Michael Tokarev <mjt@xxxxxxxxxx> wrote:
> Something like this?  (run-tested but I haven't seen the problem
> in this place)
> 
> commit 2e8532e0a9ee1d25b279ac78ee8ce31701e2aa15
> Author: Michael Tokarev <mjt@xxxxxxxxxx>
> Date:   Fri Jun 3 10:50:49 2011 +0400
> 
>     block: add proper state guards to elv_queue_empty()

Yes, that's exactly what I mean.

>     Like in 0a58e077eb600d1efd7e54ad9926a75a39d7f8ae (backported to
>     stable 2.6.38 as 0a58e077eb600d1efd7e54ad9926a75a39d7f8ae) which
>     fixes this for __elv_next_request(), as reported by Atsushi Nemoto,
>     elv_queue_empty() also needs to check for dead queue condition
>     before touchin elevator.
> 
>     elv_queue_empty() has been removed upstream so this is only applicable
>     for versions prior to 2.6.39, including 2.6.32-longterm.

Yes, Wolfgang Walter reported same crash on 2.6.32.40 so
2.6.32-longterm would need this fix.

I suppose all stable branches which have backport of 86cbfb56 ("put
stricter guards on queue dead checks") need this fix.

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/