Re: [PATCH] drivers/usb/gadget: add missing kfree calls
From: Michal Nazarewicz
Date: Sat Jun 04 2011 - 17:35:33 EST
On Sat, 04 Jun 2011 21:34:54 +0200, Andre Bartke
<andre.bartke@xxxxxxxxxxxxxx> wrote:
diff --git a/drivers/usb/gadget/rndis.c b/drivers/usb/gadget/rndis.c
@@ -700,6 +701,7 @@ static int rndis_reset_response(int configNr,
rndis_reset_msg_type *buf)
resp->AddressingReset = cpu_to_le32(1);
params->resp_avail(params->v);
+ kfree(r);
return 0;
}
Have you tested this? It does not look right to me. rndis_add_response()
allocates memory and puts the request on a list. It is later freed in
rndis_free_response().
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michal "mina86" Nazarewicz (o o)
ooo +-----<email/xmpp: mnazarewicz@xxxxxxxxxx>-----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/