[PATCH] Disable CONFIG_CONSTRUCTORS when not needed byCONFIG_GCOV_KERNEL

From: Josh Triplett
Date: Sun Jun 05 2011 - 04:21:36 EST


CONFIG_CONSTRUCTORS controls support for running constructor functions
at kernel init time. According to commit
b99b87f70c7785ab1e253c6220f4b0b57ce3a7f7, gcov (CONFIG_GCOV_KERNEL)
needs this. However, CONFIG_CONSTRUCTORS currently defaults to y, with
no option to disable it, and CONFIG_GCOV_KERNEL depends on it. Instead,
default it to n and have CONFIG_GCOV_KERNEL select it, so that the
normal case of CONFIG_GCOV_KERNEL=n will result in
CONFIG_CONSTRUCTORS=n.

Observed in the short list of =y values in a minimal kernel
configuration.

Signed-off-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
---
CCing people copied on the original commit
b99b87f70c7785ab1e253c6220f4b0b57ce3a7f7.

init/Kconfig | 1 -
kernel/gcov/Kconfig | 3 ++-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/init/Kconfig b/init/Kconfig
index ebafac4..e9bf65f 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -19,7 +19,6 @@ config DEFCONFIG_LIST
config CONSTRUCTORS
bool
depends on !UML
- default y

config HAVE_IRQ_WORK
bool
diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig
index b8cadf7..5bf924d 100644
--- a/kernel/gcov/Kconfig
+++ b/kernel/gcov/Kconfig
@@ -2,7 +2,8 @@ menu "GCOV-based kernel profiling"

config GCOV_KERNEL
bool "Enable gcov-based kernel profiling"
- depends on DEBUG_FS && CONSTRUCTORS
+ depends on DEBUG_FS
+ select CONSTRUCTORS
default n
---help---
This option enables gcov-based code profiling (e.g. for code coverage
--
1.7.5.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/