Re: [PATCH] savage: remove unecessary if statement

[Nicolas Kaiser]

* Greg Dietsche <Gregory.Dietsche@xxxxxxx>:
> the code always returns ret regardless, so if(ret) check is unecessary.
/unecessary/unnecessary/

> 
> Signed-off-by: Greg Dietsche <Gregory.Dietsche@xxxxxxx>
Reviewed-by: Nicolas Kaiser <nikai@xxxxxxxxx>

Best regards,
Nicolas Kaiser
> ---
>  drivers/gpu/drm/savage/savage_bci.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/savage/savage_bci.c b/drivers/gpu/drm/savage/savage_bci.c
> index bf5f83e..cb1ee4e 100644
> --- a/drivers/gpu/drm/savage/savage_bci.c
> +++ b/drivers/gpu/drm/savage/savage_bci.c
> @@ -647,9 +647,6 @@ int savage_driver_firstopen(struct drm_device *dev)
>  	ret = drm_addmap(dev, aperture_base, SAVAGE_APERTURE_SIZE,
>  			 _DRM_FRAME_BUFFER, _DRM_WRITE_COMBINING,
>  			 &dev_priv->aperture);
> -	if (ret)
> -		return ret;
> -
>  	return ret;
>  }
>  
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/