Re: [PATCH v14 7/9] usb:gadget: Add SuperSpeed support to the GadgetFramework

[Felipe Balbi]

On Fri, Jun 03, 2011 at 09:00:17PM +0300, Tanya Brokhman wrote:
> Hi Felipe,
> 
> > On Tue, May 31, 2011 at 04:18:27PM +0300, Tatyana Brokhman wrote:
> > > @@ -377,9 +425,10 @@ static int config_desc(struct usb_composite_dev
> > *cdev, unsigned w_value)
> > >  	u8				type = w_value >> 8;
> > >  	enum usb_device_speed		speed = USB_SPEED_UNKNOWN;
> > >
> > > -	if (gadget_is_dualspeed(gadget)) {
> > > -		int			hs = 0;
> > > -
> > > +	if (gadget->speed == USB_SPEED_SUPER)
> > 
> > if (gadget_is_superspeed(gadget)) ??
> I thought so too at first but then I decided that checking gadget->speed is
> better here because it's possible that gadget_is_superspeed() will return
> true but the actual speed will be for example HS. In that case we want to
> enter the  else of this if (else if (gadget_is_dualspeed()) {... })

ok, makes sense.

-- 
balbi

Attachment: signature.asc
Description: Digital signature