Re: [PATCH 2/3] x86-64: Clean up vsyscall emulation and removefixed-address ret

[Ingo Molnar]

* Andy Lutomirski <luto@xxxxxxx> wrote:

> Remove the fixed-address ret in the vsyscall emulation stubs.  As a
> result, int 0xcc no longer works if executed from user address space
> (which is OK -- nothing sensible should do that).
> 
> Removing support for int 0xcc in user address space cleans up the
> code considerably.
> 
> Signed-off-by: Andy Lutomirski <luto@xxxxxxx>
> ---
>  arch/x86/include/asm/vsyscall.h   |   10 ++++-
>  arch/x86/kernel/vsyscall_64.c     |   78 +++++++++++--------------------------
>  arch/x86/kernel/vsyscall_emu_64.S |   17 +--------
>  3 files changed, 32 insertions(+), 73 deletions(-)

Ok, this makes the whole series a lot more palatable!

Can i propagate the rename suggested by hpa into patch #3:

  CONFIG_COMPAT_VSYSCALL => CONFIG_LEGACY_VSYSCALL

? 'legacy' is probably the best name for this and it thus won't be 
confused with the 32-bit compat facilities we have.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/