Re: [PATCH/RFC] m68k/bitops: Make bitmap data pointer of atomic ops volatile

[Arnd Bergmann]

On Monday 06 June 2011 22:07:53 Geert Uytterhoeven wrote:
> 
> This fixes a.o.
> 
> drivers/ide/ide-io.c: In function âide_lock_hostâ:
> drivers/ide/ide-io.c:415: warning: passing argument 2 of â__constant_test_and_set_bitâ discards qualifiers from pointer target type
> drivers/ide/ide-io.c:415: warning: passing argument 2 of â__generic_test_and_set_bitâ discards qualifiers from pointer target type
> 
> Suggested-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

I think the correct fix would be to mark the variable not volatile, as it
clearly has no business be marked as such. That doesn't mean your patch
is wrong, though. It probably doesn't hurt to do both.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/