Re: 3.0.0-rc2 fails to boot on Atom appliance (bisected, drm/i915)
From: Ben Greear
Date: Tue Jun 07 2011 - 00:00:36 EST
On 06/06/2011 05:24 PM, Jesse Barnes wrote:
On Mon, 06 Jun 2011 16:59:02 -0700
Ben Greear<greearb@xxxxxxxxxxxxxxx> wrote:
On 06/06/2011 04:41 PM, Keith Packard wrote:
On Mon, 06 Jun 2011 16:26:25 -0700, Ben Greear<greearb@xxxxxxxxxxxxxxx> wrote:
On 06/06/2011 01:09 PM, Ben Greear wrote:
Anyone seen something like this? For what it's worth, it seems
that -rc1 had the same problem. I'll start bisecting soon if
the problem isn't already resolved somehow...
I bisected this problem down to this commit:
This should be fixed by this patch:
-------------------- drivers/gpu/drm/i915/intel_display.c ---------------------
index f553ddf..bb1b59b 100644
@@ -7675,6 +7675,7 @@ static void intel_init_display(struct drm_device *dev)
dev_priv->display.update_wm = NULL;
} else
dev_priv->display.update_wm = pineview_update_wm;
+ dev_priv->display.init_clock_gating = gen3_init_clock_gating;
} else if (IS_G4X(dev)) {
dev_priv->display.update_wm = g4x_update_wm;
dev_priv->display.init_clock_gating = g4x_init_clock_gating;
This hasn't been merged yet, but should be soon.
I tried adding that, but the problem stays the same.
Any other patches I should try?
Are you sure you booted the right kernel and that it built& installed
correctly?
I double checked, but I tried to cheat a bit and just applied that patch on
top of -rc2 instead of on top of the patch that breaks things according to
bisect. Maybe there is more than one problem. I'll try tweaking that single
patch tomorrow.
And, I built and booted twice to make sure I didn't screw up..but it had been
a long day of bisecting, so maybe I still messed up some how.
You could add an:
if (dev_priv->display.init_clock_gating)
above the call to display.init_clock_gating in intel_init_clock_gating
to be sure it's the same problem...
Ok, can try that too.
Thanks,
Ben
--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc http://www.candelatech.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/