Re: [PATCH 2/3] kprobes/trace: Fix kprobe selftest for gcc 4.6

[Steven Rostedt]

On Tue, 2011-06-07 at 11:22 -0700, David Daney wrote:
> On 06/07/2011 11:12 AM, Steven Rostedt wrote:
> > On Tue, 2011-06-07 at 11:08 -0700, David Daney wrote:
> >
> >>> -static int kprobe_trace_selftest_target(int a1, int a2, int a3,
> >>> -					int a4, int a5, int a6)
> >>> +/*
> >>> + * Can't be static, otherwise gcc might optimize this to
> >>> + * not be in the kallsyms table.
> >>> + */
> >>
> >> Could you make it '__used' instead?
> >>
> >
> > I can try, but the problem is not that the function itself is being
> > optimized out. It looks like its being turned into anonymous text. That
> > is, it optimized out the symbol name, not the code itself.
> >
> 
> Really it is no big deal either way.  Just a thought I had.

This actually works! I like it better.

Ingo, can you hold off on pulling, while I rebase to do it David's way?
I can add tested-by tags and fix misspellings of my other change logs as
well.

Thanks!

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/