Re: [PATCH 02/02] virtio: Add virtio platform driver

[Mike Frysinger]

On Tue, Jun 21, 2011 at 06:26, Magnus Damm wrote:
> +config VIRTIO_PLATFORM
> + Â Â Â tristate "Platform driver for virtio devices (EXPERIMENTAL)"
> + Â Â Â select VIRTIO
> + Â Â Â select VIRTIO_RING
> + Â Â Â select VIRTIO_LGUEST
> + Â Â Â ---help---
> + Â Â Â ÂThis drivers provides support for virtio based paravirtual device
> + Â Â Â Âdrivers over a platform bus.
> +
> + Â Â Â ÂIf unsure, say N.

be nice to add a note as to the name of the module if the user selects "M"

> --- /dev/null
> +++ work/drivers/virtio/virtio_platform.c    2011-03-03 16:07:31.000000000 +0900
> --- /dev/null
> +++ work/include/linux/virtio_platform.h    Â2011-03-03 15:56:54.000000000 +0900

both files lack a comment block at the top
/*
 * one line desc of file
 *
 * copyright
 *
 * license blurb
 */
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/