Re: [PATCH] USB: ehci: use packed, aligned(4) instead of removingthe packed attribute

[Alexander Holler]

Am 20.06.2011 22:07, schrieb Arnd Bergmann:
> On Monday 20 June 2011 19:39:34 Alexander Holler wrote:
> > That packed without an additional aligned() caused errors on ARM with
> > gcc 4.6 is another problem which got (currently) fixed by removing packed.
>
> Packed caused errors because it is *wrong*. The code as it was used undefined
> behavior in the language.

I don't see why using just packed was wrong. The problem occured because 
the latest gcc now uses or inforces aligned(1) for a packed struct 
without any aligned and because of that the assignment in readl() is 
done byte by byte. I'm missing the required arm knowledge and experience 
to discuss this further, I don't have a reason to look further into that 
and never wanted to make any judgement about the cause.

> > But this introduces imho doubts and uncertainty about if padding bytes
> > could be between the members, therefore I would prefer to use packed
> > with aligned instead of removing the packed.
>
> Packing was never an issue here, please stop talking about it.

Sorry, I never wanted to talk about the issue itself (I've already said 
that), I just wanted to bring in some additional clarity for people 
looking at the code.

I think if there is a packed,aligned(4) most people reading that are 
able to imaging how the struct looks like, whereas nothing (without 
packed) might leave doubts which than requires to read compiler docs or 
the generated code, if one searches a problem in that area.

Maybe my english is that bad that nobody understood that.

But it's ok. For me, that discussion was long over, two people already 
said that they prefer the struct without any packed.

About the background:
I've posted that patch, because I though I might have been the source of 
the removal of packed instead of using packed along with aligned, 
because I first posted such (removing the packed) at the mailing list 
for u-boot and only later on thought that using what was hinted to me 
over a third person (packed, aligned(4), which means the one who 
originally found and fixed the problem used packed, aligned(4) too) 
might be better (what I than posted there too).

Sorry for becoming that verbose, I normally don't gabble that much and I 
would like it if I never would have posted that silly patch.

Regards,

Alexander
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/