Re: [PATCH 2/7] debugfs: add debugfs_create_int

[Greg KH]

On Mon, Jul 04, 2011 at 02:31:25PM +0900, Akinobu Mita wrote:
> 2011/7/4 Greg KH <gregkh@xxxxxxx>:
> > On Sun, Jul 03, 2011 at 11:16:16PM +0900, Akinobu Mita wrote:
> >> Introduce debugfs_create_int() for creating a debugfs file that is used to
> >> read and write an int value.
> >
> > Um, what's wrong with the existing s32 and s64 versions that debugfs
> > already provides?
> 
> I couldn't find s32 version in linux/debugfs.h
> 
> > userspace doesn't know what "int" means for the kernel as it might be
> > running in 32bit mode with a 64bit kernel.  That is why this isn't a
> > good idea, so please convert your other patch to use the existing api
> > and change the variable type in your patch.
> 
> Shoud I add debugfs_create_s32() instead of debugfs_create_int() for
> this?

Does it have to be a signed value?  If not, just use the
debugfs_create_u32() function.  Or use that and just cast the result,
right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/