Re: [PATCH -tip, final] perf, x86: Add hw_watchdog_set_attr() in asake of nmi-watchdog on P4

[Ingo Molnar]

* Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote:

> > On P4 BUS_CYCLES would be able to co-exist with CPU_CYCLES so it 
> > will solve the P4 issue naturally as well.
> 
> i don't think it changes much, Ingo, if I change it to bus cycles I 
> still will have to setup nmi-watchdog event separately (but simply 
> with bus event).

You did not understand my point, my suggestion is to change this in 
kernel/watchdog.c:

static struct perf_event_attr wd_hw_attr = {
        .type           = PERF_TYPE_HARDWARE,
        .config         = PERF_COUNT_HW_CPU_CYCLES,

to:

static struct perf_event_attr wd_hw_attr = {
        .type           = PERF_TYPE_HARDWARE,
        .config         = PERF_COUNT_HW_BUS_CYCLES,

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/