Re: [PATCH] Fix a miswriting in ext_sd_send_cmd_get_rsp

[wwang]

On 2011å07æ11æ 10:13, çç wrote:
> From: wwang<wei_wang@xxxxxxxxxxxxxx>
>
> cppcheck reported: [staging/rts_pstor/sd.c:3730] ->  [staging/rts_pstor/sd.c:3726]: (style) Found duplicate if expressions.
> It's a miswriting, and the second if expression should be "(rsp_type == SD_RSP_TYPE_R0)"
>
> Signed-off-by: wwang<wei_wang@xxxxxxxxxxxxxx>
> ---
>   drivers/staging/rts_pstor/sd.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging/rts_pstor/sd.c
> index e4b3891..8db14dd 100644
> --- a/drivers/staging/rts_pstor/sd.c
> +++ b/drivers/staging/rts_pstor/sd.c
> @@ -3747,7 +3747,7 @@ RTY_SEND_CMD:
>   				if ((ptr[3]&  0x1E) != 0x04) {
>   					TRACE_RET(chip, STATUS_FAIL);
>   				}
> -			} else if (rsp_type == SD_RSP_TYPE_R2) {
> +			} else if (rsp_type == SD_RSP_TYPE_R0) {
>   				if ((ptr[3]&  0x1E) != 0x03) {
>   					TRACE_RET(chip, STATUS_FAIL);
>   				}

Dear all:

    Sorry to bother, please ignore this mail, I will modify the log 
resend again.

    Best regards,
    wwang

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/