Re: [PATCH 02/14] vmscan: add shrink_slab tracepoints

[Christoph Hellwig]

On Fri, Jul 08, 2011 at 02:14:34PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> ??t is impossible to understand what the shrinkers are actually doing
> without instrumenting the code, so add a some tracepoints to allow
> insight to be gained.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good.  But wouldn't it be a good idea to give the shrinkers names
so that we can pretty print those in the trace event?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/