Re: [PATCH] Remove incorrect usage of sysctl_vfs_cache_pressure

[Steven Whitehouse]

Hi,

On Mon, 2011-07-11 at 12:00 +1000, Dave Chinner wrote:
> On Mon, Jul 11, 2011 at 02:56:23AM +0530, raghu.prabhu13@xxxxxxxxx wrote:
> > From: Raghavendra D Prabhu <rprabhu@xxxxxxxxxxx>
> > 
> > In shrinker functions, sysctl_vfs_cache_pressure variable is being used while
> > trimming slab caches in general and not restricted to inode/dentry caches as
> > documented for that sysctl.
> > 
> > Raghavendra D Prabhu (1):
> >   mm/vmscan: Remove sysctl_vfs_cache_pressure from non-vfs shrinkers
> > 
> >  drivers/gpu/drm/i915/i915_gem.c |    2 +-
> 
> That's the only questionable use of it as it has nothing to do with
> filesystems.
> 
> >  fs/gfs2/glock.c                 |    2 +-
> >  fs/gfs2/quota.c                 |    2 +-
> >  fs/mbcache.c                    |    2 +-
> >  fs/nfs/dir.c                    |    2 +-
> >  fs/quota/dquot.c                |    3 +--
> >  net/sunrpc/auth.c               |    2 +-
> 
> All the others are filesystemâspecific caches and as such the use of
> vfs_cache_pressure to adjust the balance of reclaim is valid usage.
> Especially the VFS quota cache shrinkers. ;)
> 
> Cheers,
> 
> Dave.

I agree for the two GFS2 uses of this variable. There is no need to make
this change,

Steve.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/