Re: [PATCH 1/2] x86-64: Simplify cpu_has_invlpg

[Brian Gerst]

On Sun, Jul 10, 2011 at 2:18 PM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
> On 07/10/2011 06:53 AM, Brian Gerst wrote:
>> Define CONFIG_X86_INVLPG for 64-bit too, which simplifies the code.
>>
>> Signed-off-by: Brian Gerst <brgerst@xxxxxxxxx>
>
> I think a much better way to do this kind of stuff is to define
> Linux-specific CPU feature bits (which we already have quite a few of).
> ÂThat way they fall into the same mechanism as everything else that has
> switches on CPU features, we can use alternatives, and so on.

I don't think it's worth getting too fancy with this.  Even if you
used alternatives, you'd want the config option to eliminate the
alternative when compiling for 486+.

--
Brian Gerst
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/