Re: [PATCH 21/21] dynamic_debug: delete pending queries

[Jim Cromie]

On Mon, Jul 11, 2011 at 4:49 AM, Bart Van Assche <bvanassche@xxxxxxx> wrote:
> On Mon, Jul 11, 2011 at 9:46 AM, Jim Cromie <jim.cromie@xxxxxxxxx> wrote:
>> delete pending queries by re-issuing it with disabled flags
>>
>> with:
>> $> echo "module foo +ap" > <debugfs>/dynamic_debug/control
>> $> echo "module foo +apt" > <debugfs>/dynamic_debug/control
>> $> echo "module foo ap=" > <debugfs>/dynamic_debug/control
>>
>> 1st command adds a pending query on foo
>> 2nd command modifies it by adding a TID flag
>> 3rd command deletes it by setting flags to 0
>>
>> Note that the pending query matches 'ap' as required by the flags-filter,
>> but additionally has 't'.  An exact match on the query-spec is required,
>> "module foo line 10-20" would not match, and wouldnt be removed.
>
> Maybe I've missed something, but do we need both 'a' and 'p' ? Would
> 'a' alone be sufficient ?

p is for printing, not appending.
unfortunate mnemonics.
maybe 'k' for keep, instead of a for pending is better.

>
> Bart.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/