Re: [PATCH] cifs: drop spinlock before calling cifs_put_tlink

[Jeff Layton]

On Mon, 11 Jul 2011 11:40:12 -0500
Steve French <smfrench@xxxxxxxxx> wrote:

> ok - merged.
> 
> Am testing now.  If anyone else has test data on current cifs-2.6.git
> I could send pull request faster.
> 
> On Mon, Jul 11, 2011 at 9:16 AM, Jeff Layton <jlayton@xxxxxxxxxx> wrote:
> > ...as that function can sleep.
> >
> > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
> > ---
> > Âfs/cifs/connect.c | Â Â2 +-
> > Â1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> > index ceab134..dd695c5 100644
> > --- a/fs/cifs/connect.c
> > +++ b/fs/cifs/connect.c
> > @@ -2241,8 +2241,8 @@ cifs_match_super(struct super_block *sb, void *data)
> >
> > Â Â Â Ârc = compare_mount_options(sb, mnt_data);
> > Âout:
> > - Â Â Â cifs_put_tlink(tlink);
> > Â Â Â Âspin_unlock(&cifs_tcp_ses_lock);
> > + Â Â Â cifs_put_tlink(tlink);
> > Â Â Â Âreturn rc;
> > Â}
> >
> > --
> > 1.7.6
> >
> >
> 
> 
> 

Testing with all of the patches in my cifs-3.0 and cifs-3.1 branches worked fine.

-- 
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/