Re: [PATCH 01/11] watchdog: WatchDog Timer Driver Core - Add basicframework

[Mark Brown]

On Tue, Jul 12, 2011 at 01:00:25AM +0200, Lars-Peter Clausen wrote:
> On 07/11/2011 04:19 PM, Wim Van Sebroeck wrote:

> > +	/* stop the watchdog */
> > +	err = wdd->ops->stop(wdd);
> Does it really make sense to allow stop() to fail? Will this ever happen, and

Some hardware can't be stopped, sometimes depending on circumstance.

> if yes do we gain anything by sending a additional ping?

It would increase the chances that someone sees the error message, or
that it gets written to disk or whatever (especially if the watchdog
time is short).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/