Re: ia64: replace old cpumask functions with new one

[KOSAKI Motohiro]

(2011/07/07 6:14), Tony Luck wrote:
> 2011/6/23 KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>:
>> We plan to remove old obsolete cpumask functions and plan to
>> change task->cpus_allowed implementation in future.
> ...
>>  arch/ia64/kernel/smpboot.c              |   56 +++++++++++++++---------------
> 
> I get some new warnings in this file with your patch:
> 
> 
> arch/ia64/kernel/smpboot.c:454: warning: passing argument 2 of
> ‘cpumask_set_cpu’ discards qualifiers from pointer target type
> arch/ia64/kernel/smpboot.c:581: warning: passing argument 1 of
> ‘cpumask_clear’ discards qualifiers from pointer target type
> arch/ia64/kernel/smpboot.c:613: warning: passing argument 2 of
> ‘cpumask_set_cpu’ discards qualifiers from pointer target type
> arch/ia64/kernel/smpboot.c:637: warning: passing argument 2 of
> ‘cpumask_set_cpu’ discards qualifiers from pointer target type
> arch/ia64/kernel/smpboot.c:745: warning: passing argument 2 of
> ‘cpumask_clear_cpu’ discards qualifiers from pointer target type
> 
> Four of the five involve "cpu_callin_mask" which is "volatile", the other is for
> "cpu_present_mask" - not sure what the problem is for this one.

Sorry for the delay. I'm sorry for the annoying you.
But ummm.. I can't understand the author expect which effect by this volatile.
If I am correct, its volatile has no effect. we can simply remove it.

So, I'll respin this.

Thanks.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/