Re: [PATCH] dmaengine: add dma_ctrl_cmd to pass buffer stride configuration

[Linus Walleij]

On Tue, Jul 12, 2011 at 12:56 PM, Raju, Sundaram <sundaram@xxxxxx> wrote:
> [Me]
>> [Jassi]
>> > 3) TI may not have just one DMAC IP used in all the SoCs. So if you want
>> >  vendor specific defines anyway, please atleast also add DMAC version to it.
>> >  Something like
>> >>        DMA_SLAVE_CONFIG,
>> >>        FSLDMA_EXTERNAL_START,
>> >> +       TI_DMA_v1_STRIDE_CONFIG,
>>
>> Yep unless we make it generic DMA_STRIDE_CONFIG simply, this makes
>> a lot of sense.
>
> Okay, I can add one cmd for the EDMAC in DaVinci series of SoCs and
> one for SDMAC in OMAP series of SoCs.

Wait, that's two different silicon blocks right? Then you already have proof
that this spans more than one DMAC and then you can just go for a generic
DMA_STRIDE_CONFIG from day one.

That both are TI does not matter, if they are totally unrelated implementations.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/