Re: [PATCH] signals: sys_ssetmask/sys_rt_sigsuspend should useset_current_blocked()

From: Matt Fleming
Date: Tue Jul 12 2011 - 14:17:45 EST


On Mon, 11 Jul 2011 18:01:02 +0200
Oleg Nesterov <oleg@xxxxxxxxxx> wrote:

> sys_ssetmask(), sys_rt_sigsuspend() and compat_sys_rt_sigsuspend()
> change ->blocked directly. This is not correct, see the changelog in
> e6fa16ab "signal: sigprocmask() should do retarget_shared_pending()"
>
> Change them to use set_current_blocked().
>
> Another change is that now we are doing ->saved_sigmask = ->blocked
> lockless, it doesn't make any sense to do this under ->siglock.
>
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

Reviewed-by: Matt Fleming <matt.fleming@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/