Re: [PATCH 1/3] mm: vmscan: Do use use PF_SWAPWRITE from zone_reclaim

[Mel Gorman]

On Tue, Jul 12, 2011 at 10:43:47AM -0500, Christoph Lameter wrote:
> On Tue, 12 Jul 2011, Minchan Kim wrote:
> 
> > If I am not against this patch, at least, we need agreement of
> > Christoph and others and if we agree this change, we changes vm.txt,
> > too.
> 
> I think PF_SWAPWRITE should only be set if may_write was set earlier in
> __zone_reclaim. If zone reclaim is not configured to do writeback then it
> makes no sense to set the bit.
> 

That would effectively make the patch a no-op as the check for
PF_SWAPWRITE only happens if may_write is set. The point of the patch is
that zone reclaim differs from direct reclaim in that zone reclaim
obeys congestion where as zone reclaim does not. If you're saying that
this is the way it's meant to be, then fine, I'll drop the patch. While
I think it's a bad idea, I also didn't specifically test for problems
related to it and I think the other two patches in the series are more
important.

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/