Re: [stable] [PATCH] FS-Cache: Fix bounds check

[Greg KH]

On Wed, Jul 13, 2011 at 12:55:18PM +0100, David Howells wrote:
> __fscache_uncache_all_inode_pages() has a loop that goes through page index
> numbers go up to (loff_t)-1.  This is incorrect.  The limit should be
> (pgoff_t)-1 as on a 32-bit machine the pgoff_t is smaller than loff_t.
> 
> On m68k the following error is observed:
> 
> fs/fscache/page.c: In function '__fscache_uncache_all_inode_pages':
> fs/fscache/page.c:979: warning: comparison is always false due to
> limited range of data type
> 
> [Should there be a PGOFF_T_MAX constant defined?]
> 
> Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> ---
> 
>  fs/fscache/page.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)


<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/