Re: [PATCH 2/2] TTY: remove tty_locked

[Jiri Slaby]

On 07/13/2011 12:31 PM, Jiri Slaby wrote:
> --- a/drivers/tty/tty_mutex.c
> +++ b/drivers/tty/tty_mutex.c
...
> @@ -25,10 +23,7 @@ void __lockfunc tty_lock(void)
>  {
>  	struct task_struct *task = current;

Hmm I overlooked it generates a warning:
drivers/tty/tty_mutex.c: In function ‘tty_lock’:
drivers/tty/tty_mutex.c:24:22: warning: unused variable ‘task’
drivers/tty/tty_mutex.c: In function ‘tty_unlock’:
drivers/tty/tty_mutex.c:32:22: warning: unused variable ‘task’

> -	WARN_ON(__big_tty_mutex_owner == task);
> -
>  	mutex_lock(&big_tty_mutex);
> -	__big_tty_mutex_owner = task;
>  }

I will send whole series as v2 since it is confusing enough.

thanks,
-- 
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/