Re: [PATCH] regulator: Fix memory leak in set_machine_constraints()error paths

[Axel Lin]

2011/7/15 Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>:
> On Thu, Jul 14, 2011 at 09:29:19PM +0800, Axel Lin wrote:
>>  static int set_machine_constraints(struct regulator_dev *rdev,
>>       const struct regulation_constraints *constraints)
>>  {
>> -     int ret = 0;
>> +     int ret;
>>       struct regulator_ops *ops = rdev->desc->ops;
>>
>
> This doesn't look like a leak fix?  There's nothing that checks for
> other errors here (like null pointers)?
>

I think it does checking null pointer for rdev->constraints in current
implementation:

static int set_machine_constraints(struct regulator_dev *rdev,
        const struct regulation_constraints *constraints)
{
        int ret;
        struct regulator_ops *ops = rdev->desc->ops;

        rdev->constraints = kmemdup(constraints, sizeof(*constraints),
                                    GFP_KERNEL);
        if (!rdev->constraints)
                return -ENOMEM;


Regards,
Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/