Re: nohz: remove nohz_cpu_mask

[Alex,Shi]

On Tue, 2011-07-12 at 01:30 +0800, Paul E. McKenney wrote:
> On Mon, Jul 11, 2011 at 08:47:05AM +0800, Alex,Shi wrote:
> > RCU didn't use this global variable now. Currently no user on it.
> 
> Indeed.  RCU's use of it turned out to be quite buggy.  :-(
> 
> > Since the ts->do_timer_last is not the real last periodic tick cpu in
> > most of time. I once want to compare the cpu_online_mask and
> > nohz_cpu_mask to get a real one, and than only let that cpu sleep
> > shorter, other cpu will try to sleep KTIME_MAX, that need a extra lock
> > for nohz_cpu_mask. But I checked my all platforms, from NHM-EX server to
> > laptops, all of them are waked up a few times per second. So, the
> > advantage is only in theory. 
> > 
> > Since no clear usage of this variable, why not remove it? That can save
> > a cache-line in all cpus and reduce atomic sync contention.
> 
> Works for me!
> 
> Reviewed-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> 

Thomas, would you like to give some comments of this? 

Best regards!
Alex

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/