Re: [PATCH 11/11] dynamic_debug: use a single printk() to emit msgs
From: Bart Van Assche
Date: Fri Jul 15 2011 - 12:11:03 EST
On Fri, Jul 15, 2011 at 6:04 PM, Jason Baron <jbaron@xxxxxxxxxx> wrote:
> yes, but that approach uses 'KERN_CONT'. The point of patch 11/11 is to get rid
> of KERN_CONT, which is racy.
I know. What I'm trying to explain is that since patch 11/11 modifies
dynamic_emit_prefix() such that it writes its output to a buffer there
is no longer a need to write into that buffer with a single snprintf()
call. Using multiple snprintf() calls is also fine. Hence it is
possible to eliminate the two temporary arrays (tid[] and lineno[])
from dynamic_emit_prefix() without reintroducing these races.
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/