Re: [PATCH -tip v2 4/6] perf script: print DSOs and symbols for BTSbranch_from addr

[Akihiro Nagai]

(2011/07/18 1:22), David Ahern wrote:
> On 07/17/2011 03:31 AM, Akihiro Nagai wrote:
> > Print DSOs and symbols for branch_from address of BTS.
> > BTS records branch_from address in 'addr' fields,
> > and branch_to address in 'ip' field. Latest perf-script
> > resolves DSOs and symbols only for 'ip' field.
> > This patch resolves them for 'addr' field too.
>
> Description does not match code change. What you are doing is enhancing
> the detection of when a sample address should correlate to a symbol. In
> this case you are adding HW_BRANCH_INSTRUCTIONS event.
I see. In the next patch set, I'd like to fix it. For example,
"Enhance IP and ADDR correlation detection of BTS event"

Thank you.

> David
>
>
> > # perf script -f ip,addr,dso,sym
> > 3f03e016b0 (unknown) ([kernel.kallsyms]) ffffffff814675d2 irq_return ([kernel.kallsyms])
> > 3f03e016b0    _start (/lib64/ld-2.14.so) ffffffff814675d2 irq_return ([kernel.kallsyms])
> > 3f03e04b80 _dl_start (/lib64/ld-2.14.so)       3f03e016b3 _start (/lib64/ld-2.14.so)
> > 3f03e04b80 _dl_start (/lib64/ld-2.14.so) ffffffff814675d2 irq_return ([kernel.kallsyms])
> > 3f03e04ba6 _dl_start (/lib64/ld-2.14.so) ffffffff814675d2 irq_return ([kernel.kallsyms])
> > 3f03e04bad _dl_start (/lib64/ld-2.14.so) ffffffff814675d2 irq_return ([kernel.kallsyms])
> > 3f03e04c1d _dl_start (/lib64/ld-2.14.so)       3f03e04bfb _dl_start (/lib64/ld-2.14.so)
> > [snip]
> >
> > Signed-off-by: Akihiro Nagai<akihiro.nagai.hw@xxxxxxxxxxx>
> > Cc: Peter Zijlstra<peterz@xxxxxxxxxxxxx>
> > Cc: Frederic Weisbecker<fweisbec@xxxxxxxxx>
> > Cc: Paul Mackerras<paulus@xxxxxxxxx>
> > Cc: Ingo Molnar<mingo@xxxxxxx>
> > Cc: Arnaldo Carvalho de Melo<acme@xxxxxxxxxxxxx>
> > Cc: David Ahern<dsahern@xxxxxxxxx>
> > Cc: Masami Hiramatsu<masami.hiramatsu.pt@xxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/