Re: v3.0: Weird kernel log message when resuming avout NMI received

[Peter Zijlstra]

On Mon, 2011-08-01 at 15:21 +0400, Cyrill Gorcunov wrote:
> >       mutex_lock(&swhash->hlist_mutex);
> > -     if (swhash->hlist_refcount > 0) {
> > +     if (swhash->hlist_refcount > 0 && !swhash->swevent_hlist) {
> 
> Should not there be rcu_dereference(swhash->swevent_hlist)? 

swhash->hlist_mutex is the modifier lock for that rcu use and should
thus serialize things sufficiently.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/