Re: [PATCH v2] Fix leak indrivers/target/iscsi/iscsi_target_parameters.c::iscsi_copy_param_list()

From: Joe Perches
Date: Mon Aug 01 2011 - 19:32:37 EST


On Mon, 2011-08-01 at 22:32 +0200, Jesper Juhl wrote:
> diff --git a/drivers/target/iscsi/iscsi_target_parameters.c b/drivers/target/iscsi/iscsi_target_parameters.c
[]
> @@ -572,6 +572,17 @@ int iscsi_copy_param_list(
[]
> + if (!new_param->name || !new_param->value) {
[]
> + pr_err("Unable to allocate memory for parameter "
> + "name/value.\n");

I know you didn't change these lines, but could you please
remember to coalesce formats to a single line next time?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/