Re: [PATCH 2/5] acpi-cpufreq: Add support for disabling dynamicoverclocking

[Len Brown]

While this patch will work and is not invalid, I don't like it.

It advertises a user I/F that suggests that disabling turbo
is on a per logical processor basis -- but a write to
any of the attributes will write to every CPU in the system.

Either it should do per-cpu limiting (which, btw doesn't
work if you use the MISC_ENABLES MSR method in this patch,
and would instead need to use the PERF_CTL.32 method)
or there should be a per-system attribute
that reflects that this knob is per-system.

thanks,
Len Brown, Intel Open Source Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/