Re: [PATCH] rtlwifi: Fix build errors on sh4 architecture

[Larry Finger]

On 08/02/2011 03:20 PM, Felix Fietkau wrote:
> On 2011-08-02 9:54 PM, Larry Finger wrote:
> > When rtlwifi is built for the sh4 architecture, build errors of the following
> > type occur. An explicit reference to<linux/io.h> should fix these. I have not
> > setup the cross-build environment, thus this patch is untested on that platform.
> > It does not cause any problems on i386 or x86_64.
> >
> > v3.0/sh4/sh-allmodconfig v3.0/sh4/sh-allyesconfig
> > src/drivers/net/wireless/rtlwifi/rtl8192c/../pci.h:290: error: implicit
> > declaration of function 'outl': 4 errors in 2 logs
> > v3.0/sh4/sh-allmodconfig v3.0/sh4/sh-allyesconfig
> > src/drivers/net/wireless/rtlwifi/rtl8192c/../pci.h:295: error: implicit
> > declaration of function 'outb': 4 errors in 2 logs
> > v3.0/sh4/sh-allmodconfig v3.0/sh4/sh-allyesconfig
> > src/drivers/net/wireless/rtlwifi/rtl8192c/../pci.h:300: error: implicit
> > declaration of function 'inb': 4 errors in 2 logs
> > v3.0/sh4/sh-allmodconfig v3.0/sh4/sh-allyesconfig
> > src/drivers/net/wireless/rtlwifi/rtl8192c/../pci.h:305: error: implicit
> > declaration of function 'inw': 4 errors in 2 logs
> >
> > Signed-off-by: Larry Finger<Larry.Finger@xxxxxxxxxxxx>
> > Cc: Geert Uytterhoeven<geert@xxxxxxxxxxxxxx>
> > ---
> >
> > John,
> >
> > I'm not sure where this goes. I guess that 3.2 would be OK, unless someone
> > actually tries to build it on sh4. The only time I have seen the errors is
> > in Geert's listing of errors and warnings.
> I looked at the code that uses raw port access, and it looks to me like this is
> just a bunch of x86 specific hacks to mess with the ASPM settings of the PCI
> bridge. This code should probably be either #ifdef'd, removed or rewritten. I
> doubt it'll work properly on other architectures.

Thanks Felix.

John,

I'll take another look at this. Please drop the patch.

Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/