Re: [PATCH] jbd/jbd2: add pointer type conversion on void *arg fromvoid * to journal_t * explicitly in kjournald/kjournald2

[Li Zefan]

Wang Sheng-Hui wrote:
> On 2011å08æ03æ 10:04, Li Zefan wrote:
>> 09:58, Wang Sheng-Hui wrote:
>>> The patch is against 3.0
>>>
>>> The arg of kjournald/kjournald2 is void *, and points to type
>>> journal_t. We should convert it to journal_t * explicitly in
>>> the kjournald/kjournald2 function body.
>>>
>>
>> Why?
>>
>> Implicit convertion from void * to foo * is ok. Did the compiler
>> complain about this to you?
> 
> I remember any * can be assigned directly to void * in ANSI C, but
> void * should be converted to specific point * type. Right?
> 

No.

> And I checked the code of kswapd, in which explicitly conversion is
> taken on the arg *. I think it should do so in journal.c too.
> 

Please check more similar code.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/