Re: [RFC PATCH] watchdog: ep93xx: Use the WatchDog Timer Driver Core.

[Mika Westerberg]

On Tue, Aug 02, 2011 at 11:55:36AM -0500, H Hartley Sweeten wrote:
> >> -static const struct watchdog_info ident = {
> >> -	.options = WDIOF_CARDRESET | WDIOF_MAGICCLOSE,
> >> -	.identity = "EP93xx Watchdog",
> >> +static const struct watchdog_info ep93xx_wdt_ident = {
> >> +	.options	= WDIOF_CARDRESET | WDIOF_MAGICCLOSE,
> >> +	.identity	= "EP93xx Watchdog",
> >>  };

One more thing I noticed: you should add WDIOF_KEEPALIVEPING to the options
field. Otherwise it doesn't support ioctl(..., WDIOC_KEEPALIVE) which was
supported in the original driver.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/