Re: [PATCH] usb: musb: ux500: set dma config for both src and dst

[Per Forlin]

On 3 August 2011 15:31, Felipe Balbi <balbi@xxxxxx> wrote:
> On Tue, Aug 02, 2011 at 05:33:39PM +0200, Per Forlin wrote:
>> From: Per Forlin <per.forlin@xxxxxxxxxx>
>>
>> The dma driver requires both src and dst to be set.
>> This fix is needed in order to run gadget mass storage.
>> Patch is verified on snowball.
>>
>> Signed-off-by: Per Forlin <per.forlin@xxxxxxxxxx>
>
> should this go for stable too ??
>
Short answer no.

Reason:
I ran into this bug when applying upcoming dma driver patches. Adding
this patch now will makes sure the musb driver works when the dma
driver is updated..
Up until now the dma driver only use the peripheral end point
configuration and set it for both src and dst. Upcoming patches (not
sure if they are submitted yet) will allow src and dst to be different
therefore the client must set both.


> --
> balbi
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/