Re: [PATCH RFCv2 0/8] sched: Enforce order of leaf CFS runqueues(and list cleanup)
From: Peter Zijlstra
Date: Wed Aug 03 2011 - 17:36:48 EST
On Wed, 2011-08-03 at 23:05 +0200, Jan SchÃnherr wrote:
> Hi Peter,
>
> Am 27.07.2011 21:10, schrieb Jan H. SchÃnherr:
> > Patch 1: After inventing __list_link(), I realized, that this
> > function already existed, but with a different name.
> >
> > This patch just does some renaming. Not really needed,
> > but if I use the old naming in patch 2 it's really
> > hard to understand what's actually going on.
> >
> > It also helps to increase the readability of the existing
> > code, see patches 6-8.
> >
> > Patch 2: This introduces new list functions to splice RCU lists
> > and handle deleted RCU list entries.
> >
> > Patch 3: The actual bugfix.
> >
> > Patch 4+5: Follow-ups to patch 1. Some more renaming and use of
> > appropriate functions.
> >
> > Patch 6: Another follow-up to patch 1, improving the readability of
> > the list routines a bit.
> >
> > Patch 7+8: Follow-ups to patch 2. Make use of the introduced
> > functionality in the already existing code.
>
>
> I am wondering, whether v3 should consist basically only of
> patches 2 and 3, i. e. the minimal approach, or if you would
> take all of them?
>
> If you prefer the minimal version, I would make another patch
> set out of the other patches. But as there seems to be no official
> maintainer for list related functionality, I would appreciate
> some hints who I should put on the TO/CC list.
Ha, good question, so what we can do is I can take the minimal patch-set
through the scheduler tree once we un-confuse ourself with those list
ops and at least one of the Paul's has had a look too (such tricksy code
deserves more eye balls).
After that we can maybe trick Andrew Morton into carrying the generic
cleanups etc.. at any rate, try and Cc everybody who's files you're
touching on the various patches (scripts/get_maintaineres.pl --no-git or
so should get you an idea).
Alternatively we could try and trick Ingo into pushing them, but
generally Andrew is maintainer of misc. stuff.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/